[eventhubs] Update last commited LSN on metadata after we flush #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the sync flow fails this would make it so that the metadata is more up-to data. Prior to the change the metadata would only be updated once per sync flow, now this is done every 10s, so its more updated.
Amogh-Bharadwaj
approved these changes
Nov 24, 2023
|
Could the existing metadata update that we were previously doing be removed now that this is handling it more frequently? Thinking in terms of SyncFlow potentially never returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the sync flow fails this would make it so that the metadata is more up-to data. Prior to the change the metadata would only be updated once per sync flow, now this is done every 10s, so its more updated.